Skip to content

ci: resolve standalone testing #20633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 11, 2025
Merged

ci: resolve standalone testing #20633

merged 18 commits into from
Mar 11, 2025

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 10, 2025 •
edited by github-actions bot
Loading

What does this PR do?

solve false crashes with testing DDP tests and improve debugging

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20633.org.readthedocs.build/en/20633/

@github-actions github-actions bot added the ci Continuous Integration label Mar 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.2.2) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
pl-cpu (macOS-14, lightning, 3.12.7, 2.4.1) success ✅
pl-cpu (macOS-14, lightning, 3.12.7, 2.5.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
pl-cpu (ubuntu-22.04, lightning, 3.12.7, 2.4.1) success ✅
pl-cpu (ubuntu-22.04, lightning, 3.12.7, 2.5.1) success ✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.2.2) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.12.7, 2.4.1) success ✅
pl-cpu (windows-2022, lightning, 3.12.7, 2.5.1) success ✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success ✅
pl-cpu (macOS-14, pytorch, 3.12.7, 2.5.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.12.7, 2.5.1) success ✅
pl-cpu (windows-2022, pytorch, 3.12.7, 2.5.1) success ✅

These checks are required after the changes to tests/tests_pytorch/conftest.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to .azure/gpu-tests-pytorch.yml, tests/tests_pytorch/conftest.py, tests/run_standalone_tests.sh.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to .azure/gpu-benchmarks.yml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, lightning, 3.12.7, 2.4.1) success ✅
fabric-cpu (macOS-14, lightning, 3.12.7, 2.5.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (ubuntu-22.04, lightning, 3.12.7, 2.4.1) success ✅
fabric-cpu (ubuntu-22.04, lightning, 3.12.7, 2.5.1) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.12.7, 2.4.1) success ✅
fabric-cpu (windows-2022, lightning, 3.12.7, 2.5.1) success ✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success ✅
fabric-cpu (macOS-14, fabric, 3.12.7, 2.5.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.12.7, 2.5.1) success ✅
fabric-cpu (windows-2022, fabric, 3.12.7, 2.5.1) success ✅

These checks are required after the changes to tests/tests_fabric/conftest.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to .azure/gpu-tests-fabric.yml, tests/tests_fabric/conftest.py, tests/run_standalone_tests.sh.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda mentioned this pull request Mar 10, 2025
Merged
7 tasks
@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Mar 10, 2025
@Borda
Copy link
Collaborator Author

Borda commented Mar 10, 2025 •
edited
Loading

Example how you will see failed tests 🔴 https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=227501&view=logs&j=47e66f3c-897a-5428-da11-bf5c7745762e&t=0a2648f8-2f78-5868-a4d9-eb93d8d90c45&s=96ac2280-8cb4-5df5-99de-dd2da759617d

@Borda
Copy link
Collaborator Author

Borda commented Mar 10, 2025

examples of logs fr all 🟢 https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=227501&view=logs&j=3f274fac-2e11-54ca-487e-194c91f3ae9f&t=8da0b6c4-35de-5c68-3c64-0e4ce0eb560c

@codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88%. Comparing base (5073ac1) to head (3a9b875).
Report is 111 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20633   +/-   ##
=======================================
  Coverage      88%      88%           
=======================================
  Files         267      267           
  Lines       23372    23372           
=======================================
  Hits        20483    20483           
  Misses       2889     2889

@Borda Borda changed the title ci: resolve standalone testing [wip] ci: resolve standalone testing Mar 11, 2025
lantiga
lantiga approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, much needed fix, thank you @Borda!

@lantiga lantiga merged commit e8d70bc into master Mar 11, 2025
66 checks passed
@lantiga lantiga deleted the ci/fix-standalone branch March 11, 2025 07:44
@Borda Borda mentioned this pull request Mar 11, 2025
Merged
3 tasks
Borda added a commit that referenced this pull request Mar 12, 2025
@Borda
ci: resolve standalone testing (#20633)
4c50227 
* ci: resolve standalone testing

* faster

* merge

* printenv

* here

* list

* prune

* process

* printf

* stdout

* ./

* -e

* .coverage

* all

* rev

* notes

* notes

* notes

(cherry picked from commit e8d70bc)
lexierule pushed a commit that referenced this pull request Mar 18, 2025
@Borda @lexierule
ci: resolve standalone testing (#20633)
edb4451 
* ci: resolve standalone testing

* faster

* merge

* printenv

* here

* list

* prune

* process

* printf

* stdout

* ./

* -e

* .coverage

* all

* rev

* notes

* notes

* notes

(cherry picked from commit e8d70bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lantiga lantiga lantiga approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Borda @lantiga